Skip to content

Conversation

@Lipata
Copy link
Member

@Lipata Lipata commented Oct 14, 2025

Temporarily disable .spec files from linting, until proper esling is configured: #1292

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR temporarily disables linting for .spec files to address issues with ESLint configuration for test files. The changes simplify the ESLint configuration by removing Angular-specific linting rules and adding explicit ignores for spec files.

  • Removes Angular ESLint plugins and related rules from the configuration
  • Adds explicit ignores for **/*.spec.ts files in multiple places
  • Simplifies the configuration to basic TypeScript linting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

},
{
ignores: ['projects/**/*']
ignores: ['projects/**/*', '**/*.spec.ts']
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec file ignore pattern is duplicated in two places (line 8 and line 28). Consider consolidating these ignores to avoid redundancy and potential inconsistencies.

Copilot uses AI. Check for mistakes.
@coveralls
Copy link

coveralls commented Oct 14, 2025

Coverage Status

coverage: 70.252%. remained the same
when pulling 059d697 on nalipiev/eslint-standalone
into 7d174c3 on master.

@Lipata Lipata requested a review from Copilot October 14, 2025 15:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Lipata Lipata changed the title ci: temporary disable spec file linting ci: temporarily disable spec file linting Oct 14, 2025
@Lipata Lipata merged commit 3e72d24 into master Oct 14, 2025
4 checks passed
@Lipata Lipata deleted the nalipiev/eslint-standalone branch October 14, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants